feat: support expansion in gator verify #3650
Conversation
Signed-off-by: David-Jaeyoon-Lee <[email protected]>
Signed-off-by: David-Jaeyoon-Lee <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3650 +/- ##
==========================================
- Coverage 54.49% 47.75% -6.75%
==========================================
Files 134 221 +87
Lines 12329 18756 +6427
==========================================
+ Hits 6719 8956 +2237
- Misses 5116 8949 +3833
- Partials 494 851 +357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Are we going to add |
Signed-off-by: David-Jaeyoon-Lee <[email protected]>
Signed-off-by: David-Jaeyoon-Lee <[email protected]>
| @@ -9,6 +9,9 @@ var ( | |||
| // ErrNotAConstraint indicates the user-indicated file does not contain a | |||
| // Constraint. | |||
| ErrNotAConstraint = errors.New("not a Constraint") | |||
| // ErrNotAnExpansion indicates the user-indicated file does not contain a | |||
There was a problem hiding this comment.
nit: "an ExpansionTemplate"
| } | ||
|
|
||
| gvk := u.GroupVersionKind() | ||
| if gvk.Group != "expansion.gatekeeper.sh" { |
There was a problem hiding this comment.
We should test both group and kind here (we don't do that for constraints because constraints have an unknown set of kinds that all live under the same group)
| @@ -327,7 +364,32 @@ func (r *Runner) runReview(ctx context.Context, newClient func() (gator.Client, | |||
| Object: *toReview, | |||
| Source: mutationtypes.SourceTypeOriginal, | |||
| } | |||
| return c.Review(ctx, au, reviews.EnforcementPoint(util.GatorEnforcementPoint)) | |||
|
|
|||
| review, err := c.Review(ctx, au, reviews.EnforcementPoint(util.GatorEnforcementPoint)) | |||
There was a problem hiding this comment.
As a general rule in golang you should return ASAP on error.
What this PR does / why we need it:
It allows for expansion in gator verify.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3432
Special notes for your reviewer: