feat: configure scheduler on controller-manager and audit pods #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3560 +/- ##
==========================================
- Coverage 54.49% 47.71% -6.79%
==========================================
Files 134 221 +87
Lines 12329 18699 +6370
==========================================
+ Hits 6719 8922 +2203
- Misses 5116 8935 +3819
- Partials 494 842 +348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaydipGabani
requested changes
Sep 27, 2024
cmd/build/helmify/static/README.md
Outdated
| | externalCertInjection.enabled | Enable the injection of an external certificate. This disables automatic certificate generation and rotation | `false` | | ||
| | externalCertInjection.secretName | Name of secret for injected certificate | `gatekeeper-webhook-server-cert` | | ||
| | externaldataProviderResponseCacheTTL | TTL for the external data provider response cache. Specify the duration in 'h', 'm', or 's' for hours, minutes, or seconds respectively. | `3m` | | ||
| | schedulerName | Name of the kubernetes scheduler to be used for the audit and controller pods. | `3m` | |
There was a problem hiding this comment.
Suggested change
| | schedulerName | Name of the kubernetes scheduler to be used for the audit and controller pods. | `3m` | | |
| | schedulerName | Name of the kubernetes scheduler to be used for the audit and controller pods. | `default-scheduler` | |
gergelysotidm
force-pushed
the
feat/non_default_scheduler
branch
from
b203b98
to
72cf84c
Compare
|
@gergelysotidm you need to sign your commit for DCO check to pass |
gergelysotidm
force-pushed
the
feat/non_default_scheduler
branch
3 times, most recently
from
b82c877
to
8558fb7
Compare
Signed-off-by: Gergely Soti <[email protected]>
Signed-off-by: Gergely Soti <[email protected]>
gergelysotidm
force-pushed
the
feat/non_default_scheduler
branch
from
8558fb7
to
2592fdc
Compare
|
@gergelysotidm pls resolve the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enables the configuration of a non-default k8s scheduler on both the audit and controller-manager pods.
Relevant for people who run an alternate scheduler next to the default one. Especially relevant on AWS/EKS, because there the users are not allowed to configure the scheduler.
The default value will use the default k8s scheduler (if you leave the setting out, k8s will assign the pods to the default-scheduler).
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: