-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updating GK -> opa versions #3537
Conversation
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
| `v3.14.0` | `v0.57.1` | | ||
| `v3.13.0` | `v0.54.0` | | ||
| `v3.12.0` | `v0.49.2` | | ||
| `v3.11.1` | `v0.47.2` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only need to add versions after v3.15.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritazh Updated the versions. I also added a script to automate this process. Because of the script you will see there are tags and opa version added in the file that are older than 3.15.1.
Signed-off-by: Jaydip Gabani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3537 +/- ##
==========================================
- Coverage 54.49% 48.03% -6.46%
==========================================
Files 134 218 +84
Lines 12329 15167 +2838
==========================================
+ Hits 6719 7286 +567
- Misses 5116 7066 +1950
- Partials 494 815 +321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for automating this!
why is this PR adding opa version for 3.16 instead of 3.19? |
@ritazh wdym by 3.19? |
sorry I forgot to paste the link https://github.com/JaydipGabani/gatekeeper/pull/115/files#diff-7716142b7ef995ef204d6130d795699ce0509c9e4b060ba4375a7ad729194b58R10 this PR is bumping GK to 3.19 but the opa version update is for 3.16 |
Sorry about confusion. I should have been clearer in the PR description. The confusion stems from a difference in the tags between my fork and the upstream Gatekeeper (GK) repository. For instance, my fork doesn't contain the 3.17 tags, so when I run The PR I linked is a result of cutting the 3.18.0 release in my fork. Since the 3.18.0 tag doesn't exist in the upstream repo, running this command: In short, the sample PR includes only the GK-to-OPA versions that are present in both the upstream repo and my fork, due to the tag differences between the two. |
@maxsmythe PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for automating this!
What this PR does / why we need it:
Adding a step in release workflow to fetch opa versions with gatekeeper release and update the
opa-versions.md
file. This PR eliminates the need of updatingopa-versions.md
after every release.Here is an example of successful release PR - JaydipGabani#115.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: