chore: Removing setting alpha flags for vap/vapb generation unless explicitly set through helm #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3481 +/- ##
==========================================
- Coverage 54.49% 48.03% -6.47%
==========================================
Files 134 219 +85
Lines 12329 15167 +2838
==========================================
+ Hits 6719 7285 +566
- Misses 5116 7066 +1950
- Partials 494 816 +322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sozercan
approved these changes
Aug 9, 2024
…y set Signed-off-by: Jaydip Gabani <[email protected]>
JaydipGabani
force-pushed
the
alpha-flags
branch
from
b3a79c7 to
502f0d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Based on this comment #3476 (comment), we should avoid setting
alphaflags through helm. This PR only setsdefault-create-vap-for-templatesanddefault-create-vap-binding-for-constraintswhen its explicitly passed in values.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: