chore: turning default-create-vap-binding-for-constraints to true #3478
Conversation
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3478 +/- ##
==========================================
- Coverage 54.49% 48.07% -6.42%
==========================================
Files 134 219 +85
Lines 12329 15165 +2836
==========================================
+ Hits 6719 7291 +572
- Misses 5116 7058 +1942
- Partials 494 816 +322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I see we used to check if useVap label was set in the CT. https://github.com/open-policy-agent/gatekeeper/pull/3266/files#diff-474c206a215a22d369287c928c6e0785a964328557d19689e6080f978b8792ebR314 |
|
@ritazh link for relavent discussion on why we are checking for |
| @@ -65,7 +65,7 @@ import ( | |||
| var ( | |||
| log = logf.Log.V(logging.DebugLevel).WithName("controller").WithValues(logging.Process, "constraint_controller") | |||
| discoveryErr *apiutil.ErrResourceDiscoveryFailed | |||
| DefaultGenerateVAPB = flag.Bool("default-create-vap-binding-for-constraints", false, "Create VAPBinding resource for constraint of the template containing VAP-style CEL source. Allowed values are false: do not create Validating Admission Policy Binding, true: create Validating Admission Policy Binding.") | |||
| DefaultGenerateVAPB = flag.Bool("default-create-vap-binding-for-constraints", true, "Create VAPBinding resource for constraint of the template containing VAP-style CEL source. Allowed values are false: do not create Validating Admission Policy Binding, true: create Validating Admission Policy Binding. Defaults to true.") | |||
There was a problem hiding this comment.
We should not default alpha features to true. This is because alpha features should not be enabled by default.
There was a problem hiding this comment.
After talking with Rita, the idea is that generation of VAP bindings will be governed by the template only (either via default value or explicitly setting intent).
This explains #3479. B/c this requires opt-in for the feature to activate, this SGTM
|
Closing this PR since we have another change for checking |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: