fix: log panic in am #3174
Merged
fix: log panic in am #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Pana <[email protected]>
|
Needs backporting to 3.14 |
|
please feel free to create a cherry pick pr for release-3.14 after this pr merges |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3174 +/- ##
==========================================
+ Coverage 53.68% 53.81% +0.13%
==========================================
Files 136 136
Lines 12198 12198
==========================================
+ Hits 6548 6564 +16
+ Misses 5145 5133 -12
+ Partials 505 501 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
acpana
added a commit
to acpana/gatekeeper
that referenced
this pull request
Nov 30, 2023
Signed-off-by: Alex Pana <[email protected]>
maxsmythe
pushed a commit
that referenced
this pull request
Dec 5, 2023
Signed-off-by: Alex Pana <[email protected]>
openshift-merge-bot bot
pushed a commit
to stolostron/gatekeeper
that referenced
this pull request
Dec 6, 2023
…pen-policy-agent#3180) Signed-off-by: Alex Pana <[email protected]>
leewoobin789
pushed a commit
to softlee-io/gatekeeper
that referenced
this pull request
Apr 1, 2024
Signed-off-by: Alex Pana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3171
this was a dormant panic it seems that never got hit before since the log level was never exercised prior to changing the DebugLevel to 1.