Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check name length for all gk resources #3094

Merged
merged 6 commits into from
Nov 6, 2023
Merged

fix: check name length for all gk resources #3094

merged 6 commits into from
Nov 6, 2023

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Oct 20, 2023

partially addresses #3093

@acpana acpana marked this pull request as draft October 20, 2023 20:50
@acpana acpana force-pushed the acpana/fix-mut-name-length branch from ccebe11 to c1470c2 Compare October 20, 2023 22:43
@acpana acpana marked this pull request as ready for review October 23, 2023 17:53
@acpana acpana requested a review from maxsmythe October 23, 2023 18:16
maxsmythe
maxsmythe requested changes Oct 24, 2023
View reviewed changes
pkg/webhook/policy.go Outdated Show resolved Hide resolved
@acpana acpana requested a review from a team as a code owner October 30, 2023 21:23
@acpana acpana requested a review from maxsmythe October 30, 2023 21:36
maxsmythe
maxsmythe requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor fixes.

pkg/mutation/mutators/assignimage/assignimage_mutator_test.go Outdated Show resolved Hide resolved
pkg/mutation/mutators/core/errors.go Outdated Show resolved Hide resolved
pkg/mutation/mutators/testhelpers/dummy_mutator.go Outdated Show resolved Hide resolved
@acpana
review
b0c11ef 
Signed-off-by: Alex Pana <[email protected]>
@acpana acpana requested a review from maxsmythe October 31, 2023 00:39
maxsmythe
maxsmythe approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nit

pkg/mutation/mutators/testhelpers/dummy_mutator.go Outdated Show resolved Hide resolved
@acpana acpana requested review from sozercan and ritazh October 31, 2023 20:14
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (384150f) 53.10% compared to head (76a1daa) 53.25%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
+ Coverage   53.10%   53.25%   +0.15%     
==========================================
  Files         134      134              
  Lines       11897    11912      +15     
==========================================
+ Hits         6318     6344      +26     
+ Misses       5083     5075       -8     
+ Partials      496      493       -3
Flag Coverage Δ
unittests 53.25% <85.71%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/mutation/mutators/assign/assign_mutator.go 30.49% <100.00%> (+1.00%) ⬆️
...tation/mutators/assignimage/assignimage_mutator.go 44.44% <100.00%> (+6.18%) ⬆️
...mutation/mutators/assignmeta/assignmeta_mutator.go 37.14% <100.00%> (+1.22%) ⬆️
.../mutation/mutators/modifyset/modify_set_mutator.go 52.98% <100.00%> (+0.63%) ⬆️
pkg/webhook/policy.go 35.48% <100.00%> (+0.66%) ⬆️
pkg/mutation/mutators/core/mutator.go 36.84% <40.00%> (+0.17%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maxsmythe
maxsmythe approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acpana
Copy link
Contributor Author

acpana commented Nov 2, 2023

@ritazh / @sozercan PTAL when you have a chance 🙏🏼

ritazh
ritazh approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR!

@acpana acpana merged commit 2055dcc into open-policy-agent:master Nov 6, 2023
15 checks passed
@acpana acpana mentioned this pull request Nov 15, 2023
Merged
acpana added a commit to acpana/gatekeeper that referenced this pull request Nov 16, 2023
@acpana
fix: check name length for all gk resources (open-policy-agent#3094)
2702ca2 
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: alex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsmythe maxsmythe maxsmythe approved these changes

@ritazh ritazh ritazh approved these changes

@sozercan sozercan Awaiting requested review from sozercan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acpana @codecov-commenter @ritazh @maxsmythe