chore: Upgrade to k8s v0.26.1 and controller-runtime fork #2530
Conversation
maxsmythe
changed the title
Signed-off-by: Max Smythe <[email protected]>
Signed-off-by: Max Smythe <[email protected]>
Signed-off-by: Max Smythe <[email protected]>
maxsmythe
force-pushed
the
upgrade-controller-runtime-and-k8s
branch
from
2813bf3 to
17b7e9b
Compare
Signed-off-by: Max Smythe <[email protected]>
maxsmythe
force-pushed
the
upgrade-controller-runtime-and-k8s
branch
2 times, most recently
from
af03bb5 to
36b1fe8
Compare
Signed-off-by: Max Smythe <[email protected]>
maxsmythe
force-pushed
the
upgrade-controller-runtime-and-k8s
branch
from
36b1fe8 to
2ecccf2
Compare
Codecov ReportBase: 53.93% // Head: 53.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2530 +/- ##
==========================================
- Coverage 53.93% 53.75% -0.18%
==========================================
Files 116 116
Lines 10287 10295 +8
==========================================
- Hits 5548 5534 -14
- Misses 4313 4329 +16
- Partials 426 432 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
maxsmythe
changed the title
| @@ -2,16 +2,6 @@ module github.com/open-policy-agent/gatekeeper | |||
|
|
|||
| go 1.18 | |||
|
|
|||
| // Prevent otel dependencies from getting out of sync. | |||
| replace ( | |||
There was a problem hiding this comment.
we'll need to make this change in frameworks too, adding as a reminder.
pkg/readiness/setup.go
Outdated
| return tracker, nil | ||
| } | ||
|
|
||
| // SetupTracker sets up a readiness tracker and registers it to run under control of the |
There was a problem hiding this comment.
Is the comment for SetupTrackerNoReadyz?
| @@ -1,6 +1,6 @@ | |||
| # sigs.k8s.io/controller-runtime | |||
|
|
|||
| Forked from sigs.k8s.io/controller-runtime@a8c19c49e49cfba2aa486ff322cbe5222d6da533 (v0.8.2). | |||
| Forked from sigs.k8s.io/controller-runtime@6d2d247cb6f3a26e6b5597c2aa4a943a90c988bb (v0.14.1). | |||
There was a problem hiding this comment.
Is it possible to push these changes to CR upstream now that it's alot more up to date?
There was a problem hiding this comment.
We can certainly try, but I wouldn't block this PR on it.
|
Thanks for the PR @maxsmythe! The third_party stuff is becoming really hard to update/review with each update. |
Signed-off-by: Max Smythe <[email protected]>
Signed-off-by: Max Smythe <[email protected]>
|
Yeah, found this issue, which makes me hopeful that CR will eventually have something so we can remove the fork: |
…y-agent#2530) * Upgrade to k8s v0.26.1 and controller-runtime fork Signed-off-by: Max Smythe <[email protected]> * Re-add stop channel to informer map entry Signed-off-by: Max Smythe <[email protected]> * Update linter version Signed-off-by: Max Smythe <[email protected]> * Fix lint errors Signed-off-by: Max Smythe <[email protected]> * Fix broken tests Signed-off-by: Max Smythe <[email protected]> * Fix function docstring Signed-off-by: Max Smythe <[email protected]> * Fix gofumpt violation Signed-off-by: Max Smythe <[email protected]> Signed-off-by: Max Smythe <[email protected]>
Signed-off-by: Max Smythe [email protected]
What this PR does / why we need it:
Upgrade K8s and controller-runtime libraries... let's see if tests pass (WIP)
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: