Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable external data flag for helm #1633

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Nov 1, 2021

Signed-off-by: Sertac Ozercan [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@sozercan sozercan requested review from maxsmythe and ritazh November 1, 2021 22:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #1633 (866bab6) into master (c2844a6) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1633      +/-   ##
==========================================
+ Coverage   52.66%   52.86%   +0.19%     
==========================================
  Files         100      100              
  Lines        8540     8540              
==========================================
+ Hits         4498     4515      +17     
+ Misses       3684     3669      -15     
+ Partials      358      356       -2     
Flag Coverage Δ
unittests 52.86% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/config/config_controller.go 65.04% <0.00%> (ø)
pkg/watch/replay.go 81.25% <0.00%> (+2.27%) ⬆️
...onstrainttemplate/constrainttemplate_controller.go 60.71% <0.00%> (+3.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2844a6...866bab6. Read the comment docs.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan mentioned this pull request Nov 2, 2021
14 tasks
@sozercan sozercan merged commit 4031f43 into open-policy-agent:master Nov 2, 2021
@sozercan sozercan deleted the helm-externaldata branch November 2, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants