Wrap all RBAC resources in a conditional based on values.rbac.create #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 54.30% 54.10% -0.20%
==========================================
Files 94 94
Lines 8178 8178
==========================================
- Hits 4441 4425 -16
- Misses 3388 3402 +14
- Partials 349 351 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ritazh
approved these changes
Oct 23, 2021
sozercan
reviewed
Oct 25, 2021
| @@ -91,3 +91,5 @@ psp: | |||
| enabled: true | |||
| upgradeCRDs: | |||
| enabled: true | |||
| rbac: | |||
There was a problem hiding this comment.
can you add this to https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md and run make manifests?
Signed-off-by: Rob Mason <[email protected]>
…into helmconfigrbac
sozercan
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rob Mason [email protected]
What this PR does / why we need it:
Ensures that all RBAC resource creation is subject to helm value
rbac.createwhich is defaulttrue.Required for users in orgs where RBAC is managed by out of band security team and not directly from helm.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: