-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add dns policy #1624
Feat/add dns policy #1624
Conversation
Signed-off-by: Jim Conner <[email protected]>
Signed-off-by: Jim Conner <[email protected]>
Signed-off-by: Jim Conner <[email protected]>
Signed-off-by: Jim Conner <[email protected]>
110079d
to
47118d7
Compare
@notjames Can you update https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md and this should be good to merge. Thank you! |
I'll do it right now. I wasn't sure if this was automated or not. |
Signed-off-by: Jim Conner <[email protected]>
all done. Thank you! I am assuming that the |
Codecov Report
@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
+ Coverage 54.30% 54.40% +0.09%
==========================================
Files 94 94
Lines 8178 8178
==========================================
+ Hits 4441 4449 +8
+ Misses 3388 3382 -6
+ Partials 349 347 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Sertac Ozercan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jim Conner [email protected]
What this PR does / why we need it:
When using celium CNI in AWS with webhooks, containers require that
hostNet
is set totrue
anddnsPolicy
is set soClusterFirstWithHostNet
or else webhooks will fail.Special notes for your reviewer: