Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add dns policy #1624

Merged
merged 9 commits into from
Oct 26, 2021
Merged

Conversation

notjames
Copy link
Contributor

Signed-off-by: Jim Conner [email protected]

What this PR does / why we need it:
When using celium CNI in AWS with webhooks, containers require that hostNet is set to true and dnsPolicy is set so ClusterFirstWithHostNet or else webhooks will fail.

Special notes for your reviewer:

Signed-off-by: Jim Conner <[email protected]>
@notjames notjames force-pushed the feat/add-dns-policy branch from 110079d to 47118d7 Compare October 22, 2021 00:43
@notjames notjames requested a review from sozercan October 22, 2021 20:36
@sozercan
Copy link
Member

@notjames Can you update https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md and this should be good to merge. Thank you!

@notjames
Copy link
Contributor Author

@notjames Can you update https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md and this should be good to merge. Thank you!

I'll do it right now. I wasn't sure if this was automated or not.

@notjames
Copy link
Contributor Author

notjames commented Oct 22, 2021

@notjames Can you update https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md and this should be good to merge. Thank you!

I'll do it right now. I wasn't sure if this was automated or not.

all done. Thank you! I am assuming that the Chart.yaml version is bumped by CI?

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #1624 (cd71248) into master (7526893) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
+ Coverage   54.30%   54.40%   +0.09%     
==========================================
  Files          94       94              
  Lines        8178     8178              
==========================================
+ Hits         4441     4449       +8     
+ Misses       3388     3382       -6     
+ Partials      349      347       -2     
Flag Coverage Δ
unittests 54.40% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/config/config_controller.go 65.04% <0.00%> (-1.33%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 59.90% <0.00%> (+1.67%) ⬆️
pkg/watch/replay.go 81.25% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5554c6e...cd71248. Read the comment docs.

Signed-off-by: Sertac Ozercan <[email protected]>
@sozercan sozercan requested a review from maxsmythe October 22, 2021 23:47
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit e55aa36 into open-policy-agent:master Oct 26, 2021
@sathieu
Copy link
Contributor

sathieu commented Nov 23, 2021

This PR broke gatekeeper installation in my setup.

As said in doc:

Note: "Default" is not the default DNS policy. If dnsPolicy is not explicitly specified, then "ClusterFirst" is used.

I will create a PR to use ClusterFirst as default.

EDIT: Done by #1676.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants