Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add show-builtin-errors flag for the verify command #901

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

jalseth
Copy link
Member

@jalseth jalseth commented Dec 21, 2023

This is useful to raise config parsing errors when using the parse_config builtins. Previously, the unit test would fail but it was unclear to the user whether that was due to an error in the policy logic or a typo in the config.

This is useful to raise config parsing errors when using the parse_config
builtins. Previously, the unit test would fail but it was unclear to the
user whether that was due to an error in the policy logic or a typo in
the config.

Signed-off-by: James Alseth <[email protected]>
@jalseth jalseth requested a review from jpreese December 21, 2023 18:56
Copy link
Member

@boranx boranx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! we have a similar flag for [internal/commands/test.go] and it makes sense to have a similar flag set in unit-testing too

@boranx
Copy link
Member

boranx commented Jan 3, 2024

and happy new year all 🥳 🎉

@jalseth jalseth merged commit 0b9b2c6 into master Jan 3, 2024
7 checks passed
@jalseth jalseth deleted the verify-builtin-errs branch January 3, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants