Remove scheme from OCI URL before parsing it #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linter appears to be failing due to unrelated code? UPDATE: Added a new commit to fix issues reported by linter. |
lcarva
added a commit
to lcarva/ec-cli
that referenced
this pull request
Mar 20, 2023
User reported error: error validating image ... of component ...: client get: error downloading 'https://quay.io/hacbs-contract/ec-release-policy:latest': reference: invalid reference: invalid repository The issue is due to a recent change in the conftest downloader. Since that fix is not yet merged, this commit picks up the fix from my fork: open-policy-agent/conftest#796 Signed-off-by: Luiz Carvalho <[email protected]>
Without this change, registry.ParseReference throws an error if the URL contains a scheme, e.g. https://. Signed-off-by: Luiz Carvalho <[email protected]>
Thanks for the feedback! Update the PR to include a single commit. |
jalseth
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, registry.ParseReference throws an error if the URL contains a scheme, e.g. https://.