-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow data-only bundles #754
Conversation
It looks like the failures are due to some underlying CI issue?
|
yeah, recently the build image has been updated to focal, and seems like it comes with py 3.8 |
Thanks @boranx for fixing that. I've approved and merged the change. |
14cd2fc
to
04164c0
Compare
Thanks! Checks are now passing after rebasing. |
I realized I opened this PR without providing much context. A data-only bundle would be useful for my use case because it allows my policies to be customizable by simply using a different data set. For example, I have a rego rule that verifies an image reference comes from a list of allowed OCI registries. I want the list of allowed registries to be customizable without having to change the rego rule. There's a workaround that can be used to avoid this change:
Basically, use an empty policy to satisfy the requirement. That feels a bit clunky and may have unintended side-effects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor changes requested.
04164c0
to
4fa1920
Compare
This commit allows the command `conftest push` to create a bundle that contains data but no policies. Signed-off-by: Luiz Carvalho <[email protected]>
4fa1920
to
4909691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm too
thanks for the PR @lcarva 👍
I think I addressed all the review comments. Let me know if there's anything else needed to merge this. 🙏 |
0.37 includes the data only bundles support from open-policy-agent/conftest#754 which I'd like to use to push a data bundle.
This commit allows the command
conftest push
to create a bundle that contains data but no policies.Signed-off-by: Luiz Carvalho [email protected]