Move KeyValueIterable and KeyValueIterableView from trace to common #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: code coverage does not change |
|
@xukaren - Karen, did you guys actually merge it? Looks like it's closed by not merged? |
|
oh I see, basically you are collecting fixes in your repo, then gonna do one big pull request into mainline? |
|
@xukaren - absolutely not a problem. I actually appreciate tagging me, I would love to have an early peek at your work before you submit it for formal PR review in the mainline branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple PR based on this comment from @maxgolov.
Since
KeyValueIterableis used by metrics, traces, and logs alike, it would be better if it belonged to the “common” namespace as it is no longer exclusive to being used for “trace”.In this PR,
KeyValueIterableand the derived classKeyValueIterableVieware refactored from namespacetrace::*tocommon::*and their corresponding*.hfiles are moved fromapi/.../tracetoapi/.../common.The change continues to pass the key_value_iterable_view_test.cc, which runs unit tests for the abstract KeyValueIterable class and KeyValueIterableView inherited class, and does not break the build tests.
cc @alolita @MarkSeufert