Remove the proto dependency in goldendataset for traces #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
reviewed
May 24, 2021
consumer/pdata/common.go
Outdated
Comment on lines
357
to
360
| func NewAttributeMapFromKeyValues(orig *[]otlpcommon.KeyValue) AttributeMap { | ||
| return AttributeMap{orig} | ||
| } | ||
|
|
There was a problem hiding this comment.
How is this different from newAttributeMap()? Do both need to exist? If so, one should probably be implemented in terms of the other:
Suggested change
| func NewAttributeMapFromKeyValues(orig *[]otlpcommon.KeyValue) AttributeMap { | |
| return AttributeMap{orig} | |
| } | |
| func NewAttributeMapFromKeyValues(orig *[]otlpcommon.KeyValue) AttributeMap { | |
| return newAttributeMap(orig) | |
There was a problem hiding this comment.
They are the same. But if I export newAttributeMap(orig *[]otlpcommon.KeyValue) by capitalize the first letter, the compiler will complaint that it conflicts with the existing NewAttributeMap() method. Do you know if there is a better approach for this kind of situation?
Co-authored-by: Anthony Mirabella <[email protected]>
Aneurysm9
approved these changes
May 26, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove the proto dependency in
goldendatasetfor generating traces. Functions being called by GenerateTraces() will use PData instead of protos for the final constructing of Traces.Link to tracking Issue:
3229
Testing: The unit test is updated to use PData in test cases.