Added doc.go files to the consumer package and subpackages #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add initial implementation of pdatagrcp This is needed because if we split pdata, we will nolonger be able to depend on the InternalRep or generated proto classes (raw, grpc). The pdatagrcp will eventually be public once we stabilize the API. The API in the pdatagrcp package is inspired from the grpc generated classes and redirects all calls to the generated classes. Some simple renames: * TraceService[Client|Server] -> Traces[Client|Server] * MetricsService[Client|Server] -> Metrics[Client|Server] * LogsService[Client|Server] -> Logs[Client|Server] Other changes: * Replace usages of grpc generated classes in otlpexporter to excercise this new package. * Left some TODOs for the moment until this package is used more to determine the right API. Signed-off-by: Bogdan Drutu <[email protected]> * Add details for the TODOs left Signed-off-by: Bogdan Drutu <[email protected]>
…emetry#3236) Signed-off-by: Bogdan Drutu <[email protected]>
…en-telemetry#3237) Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
This commit ensures that PR builds will not use circleci contexts as any jobs depending on contexts can only be executed by otel members.
This change improves the failure message for the TestBallastMemory. While this won't solve the problem, it will help understand if we are barely above the limit, or if the test went considerably above the max. Signed-off-by: Juraci Paixão Kröhling <[email protected]>
…or/Exporter (open-telemetry#3227) * Change Receiver to match pattern with structs and helpers * Added support for ReceiverSettings * Add receiver to end functions * Add comments for new receiver * Add entry to changelog * Cache the recevier in structs * Cache the receiver in other files * Fix name for var and fix caching * Fix caching so there is no race * Fix unit tests * Add deprecated old funcs back * Fix comments
) * [wip] Introduce model translation and encodings interfaces This is a somewhat more limited version of open-telemetry#3044. It decouples translation of models from encodings. Models refers to the in-memory representation of a protcol like the zipkin v2 SpanModel. After translating from pdata to the model an encoding is used to serialize the model to a particular byte representation (protobuf, JSON, etc.). The reverse also applies in deserializing an encoding of bytes to a model then translating the model to pdata. * use encode/decode consistently * review feedback * decouple encoding from model Before the encoder interfaces took pdata and serialized it by calling the translator. This fully separates the concerns by having model do pure translation, encoding do pure serialization, and the transcoder doing both. Without this there was no way to use the encoder if you already had a model. Only updates traces for feedback purposes. * add high level interface * standardized on encoding/decoding terminology * renamed encodings to bytes to avoid confusion with encode/decode terminology * added high level interfaces to top level protocols package that goes directly pdata <-> bytes * cleanup * Apply suggestions from code review Co-authored-by: Tigran Najaryan <[email protected]> * renamings * reword error * cleanup * return interface instead of out parameter * review feedback * serialize -> marshal * put in internal * lint Co-authored-by: Tigran Najaryan <[email protected]>
alolita
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR creates or moves the documentation of the consumer package and all of its subpackages to a separate doc.go to maintain consistency with the other modules.
Link to tracking Issue:
Addresses part of issue opentelemetry-collector/issues/3050