-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __optnone__ attribute for Clang #4716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…point Thanks to @kiranchandramohan for the suggestion Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 5c4185a)
See how the various compilers handle these Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit db8ebd3)
jsquyres
requested changes
Jan 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #4715 (comment).
Per https://gcc.gnu.org/onlinedocs/gcc/Alternate-Keywords.html#index-_005f_005fextension_005f_005f, use __extension__ in a C statement that will actually verify if the compiler supports it or not. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit ff31da6)
jsquyres
approved these changes
Jan 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added cherry-pick of 0e723b5 from master. 👍
bot:ompi:retest |
Tagging this as a 3.1.0 blocker because it's been merged into 3.0.1... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the optnone attribute to help avoid optimizing out MPIR_Breakpoint
Signed-off-by: Ralph Castain [email protected]