Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __optnone__ attribute for Clang #4716

Merged
merged 3 commits into from
Jan 31, 2018
Merged

Add __optnone__ attribute for Clang #4716

merged 3 commits into from
Jan 31, 2018

Conversation

rhc54
Copy link
Contributor

@rhc54 rhc54 commented Jan 15, 2018

Add the optnone attribute to help avoid optimizing out MPIR_Breakpoint

Signed-off-by: Ralph Castain [email protected]

Ralph Castain added 2 commits January 15, 2018 11:17
…point

Thanks to @kiranchandramohan for the suggestion

Signed-off-by: Ralph Castain <[email protected]>
(cherry picked from commit 5c4185a)
See how the various compilers handle these

Signed-off-by: Ralph Castain <[email protected]>
(cherry picked from commit db8ebd3)
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per
https://gcc.gnu.org/onlinedocs/gcc/Alternate-Keywords.html#index-_005f_005fextension_005f_005f,
use __extension__ in a C statement that will actually verify if the
compiler supports it or not.

Signed-off-by: Jeff Squyres <[email protected]>
(cherry picked from commit ff31da6)
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added cherry-pick of 0e723b5 from master. 👍

@bwbarrett
Copy link
Member

bot:ompi:retest

@bwbarrett
Copy link
Member

Tagging this as a 3.1.0 blocker because it's been merged into 3.0.1...

@bwbarrett bwbarrett merged commit 4324c00 into open-mpi:v3.1.x Jan 31, 2018
@rhc54 rhc54 deleted the cmr31/optnone branch February 23, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants