smsc/xpmem: alignment and stack memory space #10127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bounds when it comes to rcache registration are the last byte of the range. Probably doesn't matter much here as no rcache is in use. |
devreal
force-pushed
the
smsc-xpmem-fixes
branch
from
ae71d72
to
70b7ee2
Compare
|
I changed the fallback to align to the actual page size, which seems to work as well and reduces the number of times we may need to remap until we have mapped all the relevant stack positions mapped. |
|
@hjelmn Can you please take a look at this PR? |
6 tasks
devreal
force-pushed
the
smsc-xpmem-fixes
branch
from
70b7ee2
to
92f2e0e
Compare
|
Rebased to current |
bwbarrett
approved these changes
Sep 19, 2022
|
bot:aws:retest |
|
@devreal I think you'll want to rebase and force push again. |
The upper bound of the mapped region must include the last byte of the range and not reach past the aligned range. Signed-off-by: Joseph Schuchart <[email protected]>
…pped The aligned range computed in mca_smsc_xpmem_map_peer_region may reach past the end of the stack, which may cause the mapping to fail. Retrying with an actual page as upper bound has a better chance to succeed. Signed-off-by: Joseph Schuchart <[email protected]>
devreal
force-pushed
the
smsc-xpmem-fixes
branch
from
92f2e0e
to
4201c94
Compare
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues identified in #10121:
Signed-off-by: Joseph Schuchart [email protected]