Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BTL checkpoint friendly #1

Closed
ompiteam opened this issue Oct 1, 2014 · 5 comments
Closed

BTL checkpoint friendly #1

ompiteam opened this issue Oct 1, 2014 · 5 comments
Assignees
@bosilca
Labels
enhancement Severity: minor

Comments

@ompiteam
Copy link
Contributor

ompiteam commented Oct 1, 2014

So far only self and tcp seems to be check-friendly. SM has a small issue, but that might be removed with a little work. All others BTL has to be investigated. A testing file will be added shortly once I figure out how to do it ...
@ompiteam
Copy link
Contributor Author

ompiteam commented Oct 1, 2014

Imported from trac issue 19. Created by bosilca on 2006-05-19T14:05:54, last modified: 2008-10-23T20:59:56

  • bosilca attached ft-test.c on 2006-05-19 14:17:48

@ompiteam
Copy link
Contributor Author

ompiteam commented Oct 1, 2014

Trac comment by jjhursey on 2007-03-13 10:52:54:

It seems that the attached program tests to see if Open MPI can successfully fork, and have the child shut down the OMPI layer. So for this bug is it sufficient to show that a BTL can operate correctly under fork conditions to be ''checkpoint friendly''? I guess I'm just searching for what you mean by a ''checkpoint friendly BTL'' since it can mean loads of different things.

@ompiteam
Copy link
Contributor Author

ompiteam commented Oct 1, 2014

Trac comment by jsquyres on 2008-10-23 11:24:19:

Josh has done a bunch of work to make various BTL's checkpointable. Is this ticket necessary? It's not really clear what the exact intent of this ticket is.

@ompiteam
Copy link
Contributor Author

ompiteam commented Oct 1, 2014

Trac comment by bosilca on 2008-10-23 20:59:56:

This program try to clean the OMPI internal state before taking a checkpoint. If a BTL pass this test, then it can be safely used with BLCR to do a uncoordinated checkpoint. I'm in favor of keeping this open ...

This was referenced Oct 1, 2014
Closed
Closed
mike-dubman added a commit that referenced this issue Oct 1, 2014
@mike-dubman
Implementing comment #1 from http://www.open-mpi.org/community/lists/…
92fdbbd 
…devel/2013/12/13523.php

Refs trac:4011

This commit was SVN r30024.

The following Trac tickets were found above:
  Ticket 4011 --> https://svn.open-mpi.org/trac/ompi/ticket/4011
rhc54 pushed a commit that referenced this issue Oct 12, 2014
Merge pull request #1 from jsquyres/topic/am-conditional-fixes
ecf9846 
configure.ac: fix some broken AM_CONDITIONALs
@rhc54 rhc54 mentioned this issue Oct 15, 2014
Closed
elenash referenced this issue Nov 26, 2014
@bosilca
Merge pull request #285 from bosilca/master
8cae899 
Reenable high accuracy timers
@osvegis osvegis mentioned this issue Feb 9, 2015
Closed
@opoplawski opoplawski mentioned this issue Mar 16, 2015
Open
jsquyres pushed a commit that referenced this issue Mar 16, 2015
@maxlevesque
Merge pull request #1 from maxlevesque/maxlevesque-patch-1
7bc3f2c 
correct path to configure file
@sushmith sushmith mentioned this issue Jul 27, 2015
Closed
jsquyres added a commit that referenced this issue Aug 31, 2015
@jsquyres
Fortran: update a comment
596557e 
Split the list of subroutines into cases #1 and #2, just for clarity.
@gpaulsen gpaulsen mentioned this issue Sep 8, 2015
Closed
bosilca referenced this issue in bosilca/ompi Sep 15, 2015
@jsquyres @bosilca
Fortran: update a comment
b292d6b 
Split the list of subroutines into cases #1 and #2, just for clarity.
jsquyres referenced this issue in jsquyres/ompi Nov 10, 2015
@jsquyres
Fortran: update a comment
27ec238 
Split the list of subroutines into cases #1 and #2, just for clarity.

(cherry picked from commit 596557e)
@gpaulsen gpaulsen mentioned this issue Dec 11, 2015
Closed
@sjeaugey sjeaugey mentioned this issue Dec 11, 2015
Closed
@sekifjikkatsu sekifjikkatsu mentioned this issue Dec 21, 2015
Closed
@matcabral matcabral mentioned this issue Jan 19, 2016
Closed
@sjeaugey sjeaugey mentioned this issue Jan 26, 2016
Closed
@markalle markalle mentioned this issue Mar 7, 2016
Closed
hjelmn added a commit that referenced this issue Mar 18, 2016
@hjelmn
osc: fix coverity issues
2ed4501 
Fix CID 1324726 (#1 of 1): Free of address-of expression (BAD_FREE):

Indeed, if a lock conflicts with the lock_all we will end up trying to
free an invalid pointer.

Fix CID 1328826 (#1 of 1): Dereference after null check (FORWARD_NULL):

This was intentional but it would be a good idea to check for
module->comm being non_NULL to be safe. Also cleaned out some checks
for NULL before free().

Signed-off-by: Nathan Hjelm <[email protected]>
hjelmn added a commit that referenced this issue Mar 18, 2016
@hjelmn
coll/base: fix coverity issues
2f4e532 
Fix CID 1325868 (#1 of 1): Dereference after null check (FORWARD_NULL):
Fix CID 1325869 (#1-2 of 2): Dereference after null check (FORWARD_NULL):

Here reqs can indeed be NULL. Added a check to
ompi_coll_base_free_reqs to prevent dereferencing NULL pointer.

Signed-off-by: Nathan Hjelm <[email protected]>
hjelmn added a commit that referenced this issue Mar 18, 2016
@hjelmn
coll/ml: fix coverity issues
c8b077f 
Fix CID 715744 (#1 of 1): Logically dead code (DEADCODE):
Fix CID 715745 (#1 of 1): Logically dead code (DEADCODE):

The free of scratch_num in either place is defensive programming. Instead of removing the free the conditional around the free has been removed to quiet the warning.

Fix CID 715753 (#1 of 1): Dereference after null check (FORWARD_NULL):
Fix CID 715778 (#1 of 1): Dereference before null check (REVERSE_INULL):

Fixed the conditional to check for collective_alg != NULL instead of collective_alg->functions != NULL.

Fix CID 715749 (#1 of 4): Explicit null dereferenced (FORWARD_NULL):

Updated code to ensure that none of the parse functions are reached with a non-NULL value.

Fix CID 715746 (#1 of 1): Logically dead code (DEADCODE):

Removed dead code.

Fix CID 715768 (#1 of 1): Resource leak (RESOURCE_LEAK):
Fix CID 715769 (#2 of 2): Resource leak (RESOURCE_LEAK):
Fix CID 715772 (#1 of 1): Resource leak (RESOURCE_LEAK):

Move free calls to before error checks to cleanup leak in error paths.

Fix CID 741334 (#1 of 1): Explicit null dereferenced (FORWARD_NULL):

Added a check to ensure temp is not dereferenced if it is NULL.

Fix CID 1196605 (#1 of 1): Bad bit shift operation (BAD_SHIFT):

Fixed overflow in calculation by replacing int mask with 1ul.

Signed-off-by: Nathan Hjelm <[email protected]>
jsquyres pushed a commit that referenced this issue Jul 7, 2017
@tjcw
Merge pull request #1 from jsquyres/tjcw-tjcw-fix-mpi-sizeof
3e6a196 
README: minor tweak to specifically mention GNU Fortran
gpaulsen pushed a commit that referenced this issue Jul 11, 2017
@jjhursey
Revert "Merge pull request #1 from jsquyres/tjcw-tjcw-fix-mpi-sizeof"
23ee602 
This reverts commit 3e6a196, reversing
changes made to 5de3d5d.

 Signed-off-by: Joshua Hursey <[email protected]>
@awlauria awlauria mentioned this issue Aug 30, 2017
Closed
@bwbarrett
Copy link
Member

We've removed all the C/R stuff, so this doesn't seem important at this point.

@xavier1arm xavier1arm mentioned this issue Sep 13, 2017
Closed
@npe9 npe9 mentioned this issue Oct 13, 2017
Closed
@teonnik teonnik mentioned this issue Oct 28, 2017
Closed
@mathbird mathbird mentioned this issue Nov 17, 2017
Closed
@ceandrade ceandrade mentioned this issue Dec 6, 2017
Closed
@hjelmn hjelmn mentioned this issue Jan 9, 2018
Closed
@smguzik smguzik mentioned this issue Jan 24, 2018
Closed
@sam6258 sam6258 mentioned this issue Feb 21, 2018
Open
dong0321 referenced this issue in dong0321/ompi Feb 22, 2018
Merge pull request #1 from pmix/topic/cleanup
be09aca 
Remove build product, add required help files
@Noxoomo Noxoomo mentioned this issue Feb 25, 2018
Closed
@amckinstry amckinstry mentioned this issue Jun 22, 2018
Closed
@mksully22 mksully22 mentioned this issue Jul 23, 2018
Closed
@LiweiPeng LiweiPeng mentioned this issue Jul 25, 2018
Closed
@amckinstry amckinstry mentioned this issue Oct 4, 2018
Merged
@bsergentm bsergentm mentioned this issue Oct 24, 2018
Closed
@regel regel mentioned this issue Nov 24, 2018
Closed
@ax3l ax3l mentioned this issue Jan 6, 2019
Closed
@hjelmn hjelmn mentioned this issue Jan 15, 2019
Closed
@iassiour iassiour mentioned this issue Apr 24, 2019
Closed
@ghost ghost mentioned this issue Jun 5, 2019
Closed
@hjelmn hjelmn mentioned this issue Jul 15, 2019
Closed
@mwheinz mwheinz mentioned this issue Jul 26, 2019
Closed
@npe9 npe9 mentioned this issue Aug 6, 2019
Merged
@opoplawski opoplawski mentioned this issue Aug 29, 2019
Closed
@open-mpi open-mpi locked as resolved and limited conversation to collaborators Dec 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bosilca bosilca

Labels
enhancement Severity: minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bosilca @ompiteam @bwbarrett