-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPMITool: futurize it #561
Conversation
Hi Howard, this has issues for python 2.7. I will look into this further.
|
I'll investigate too. |
This works for my with my python 2.7 setup. You have future installed right? |
I noticed on our machines this works:
But this does not work:
|
Future is installed on our machines. Python version is Python 2.7.9 |
1447d1c
to
a708907
Compare
@ribab now try, doing things a different way. Works for me with my python. Also futurized Environ.py. |
futurized another thing. unicode type doesn't exist explicitly with python3. |
1b1841f
to
a6d9c4b
Compare
Okay try again with IMPITool to futurize it to work both with Python 2 and later Also, futurize Environ.py so python 3 doesn't panic with print statements. Python 3 doesn't have a special unicode type. Conditionally check for unicode type for value only when using Python 2. Signed-off-by: Howard Pritchard <[email protected]>
a6d9c4b
to
483fed9
Compare
I don't have any tests that use IPMITool I can use to test this, however everything compiles with no syntax errors now. I will approve this request. |
I'm not an reviewer, so @noahv has to approve. |
IPMITool: futurize it
the IPMITool wasn't working with python3. Change
so that, provided future is installed with python,
it can work both with python 2 and 3. We already
require future for other parts of pyclient.
Signed-off-by: Howard Pritchard [email protected]