Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support OC-SORT for MOT #545

Merged
merged 18 commits into from
Aug 16, 2022
Merged

[Feature] Support OC-SORT for MOT #545

merged 18 commits into from
Aug 16, 2022

Conversation

noahcao
Copy link
Contributor

@noahcao noahcao commented May 5, 2022

Support Observation-Centric SORT: Rethinking SORT for Robust Multi-Object Tracking (official code, arxiv).

The implementation has been verified on the MOT17-val set.

[WIP]:

  1. Polish the readme file at configs/mot/ocsort/README.md
  2. Add results on MOT17-test and DanceTrack dataset to check the alignment with the official implementation.

@OceanPang OceanPang requested review from OceanPang and GT9505 May 5, 2022 06:23
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #545 (094a7b5) into master (79f8e19) will decrease coverage by 0.48%.
The diff coverage is 63.63%.

❗ Current head 094a7b5 differs from pull request most recent head e4efaa1. Consider uploading reports for the commit e4efaa1 to get more accurate results

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   73.32%   72.83%   -0.49%     
==========================================
  Files         131      132       +1     
  Lines        8191     8338     +147     
  Branches     1581     1604      +23     
==========================================
+ Hits         6006     6073      +67     
- Misses       1691     1757      +66     
- Partials      494      508      +14     
Flag Coverage Δ
unittests 72.78% <63.63%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmtrack/models/motion/__init__.py 100.00% <ø> (ø)
mmtrack/models/trackers/byte_tracker.py 90.22% <ø> (ø)
mmtrack/models/mot/ocsort.py 31.25% <31.25%> (ø)
mmtrack/models/trackers/ocsort_tracker.py 67.82% <67.82%> (ø)
mmtrack/models/mot/__init__.py 100.00% <100.00%> (ø)
mmtrack/models/trackers/__init__.py 100.00% <100.00%> (ø)
mmtrack/models/trackers/tracktor_tracker.py 63.95% <0.00%> (-15.12%) ⬇️
mmtrack/models/reid/base_reid.py 78.26% <0.00%> (-8.70%) ⬇️
mmtrack/datasets/pipelines/processing.py 70.90% <0.00%> (-3.04%) ⬇️
mmtrack/models/sot/siamrpn.py 79.88% <0.00%> (-1.68%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tools/convert_datasets/mot/mot2coco.py Outdated Show resolved Hide resolved
tools/convert_datasets/mot/mot2coco.py Outdated Show resolved Hide resolved
tools/dist_train.sh Outdated Show resolved Hide resolved
configs/mot/ocsort/README.md Show resolved Hide resolved
configs/mot/ocsort/README.md Show resolved Hide resolved
mmtrack/models/trackers/byte_tracker.py Show resolved Hide resolved
mmtrack/models/trackers/oc_sort.py Outdated Show resolved Hide resolved
mmtrack/models/trackers/oc_sort.py Outdated Show resolved Hide resolved
mmtrack/models/trackers/oc_sort.py Outdated Show resolved Hide resolved
mmtrack/models/trackers/oc_sort.py Outdated Show resolved Hide resolved
mmtrack/models/motion/__init__.py Outdated Show resolved Hide resolved
mmtrack/models/trackers/ocsort_tracker.py Show resolved Hide resolved
mmtrack/models/trackers/ocsort_tracker.py Show resolved Hide resolved
mmtrack/models/trackers/ocsort_tracker.py Show resolved Hide resolved
mmtrack/models/trackers/ocsort_tracker.py Outdated Show resolved Hide resolved
mmtrack/models/trackers/ocsort_tracker.py Show resolved Hide resolved
mmtrack/models/trackers/ocsort_tracker.py Outdated Show resolved Hide resolved
mmtrack/models/trackers/ocsort_tracker.py Show resolved Hide resolved
mmtrack/models/trackers/ocsort_tracker.py Outdated Show resolved Hide resolved
@noahcao noahcao requested a review from GT9505 June 4, 2022 01:42
Copy link
Collaborator

@GT9505 GT9505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this PR after finishing the following items:

  1. fix the comments and lint error
  2. align the training performance of OCSORT
  3. use ./tools/analysis/publish_model.py to prepare the pre-trained weights of OCSORT
  4. update the README.md and metafile.yml of OCSORT

@GT9505
Copy link
Collaborator

GT9505 commented Jun 18, 2022

Hi~@noahcao, just a kind reminder in case you forgot it :)

@noahcao noahcao requested a review from GT9505 August 15, 2022 15:40
@GT9505 GT9505 merged commit bcc0c9b into open-mmlab:master Aug 16, 2022
@noahcao noahcao mentioned this pull request Aug 17, 2022
AStar9999 added a commit to AStar9999/mmtracking that referenced this pull request Jun 2, 2023
* [WIP] support OC-SORT

* fix config

* implement OC-SORT, verified on MOT17-val

* edit OC-SORT readme

* fixed issue from code review suggestions

* format fix

* fix comments / format issues

* add unit test for oc-sort

* update mot17-reproduce results

* fixed issue mentioned in open-mmlab/mmtracking#545

* resolve conflict

* add trained weights and log

* update ocsort metafile.yml

* fix format

* fix typo

Co-authored-by: Jinkun Cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants