Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: upsampe_cfg -> upsample_cfg #449

Merged
merged 4 commits into from
Mar 30, 2021
Merged

Conversation

innerlee
Copy link
Contributor

Signed-off-by: lizz [email protected]

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #449 (a4ac71d) into master (340132d) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   86.37%   86.51%   +0.14%     
==========================================
  Files          97       97              
  Lines        4960     4962       +2     
  Branches      805      807       +2     
==========================================
+ Hits         4284     4293       +9     
+ Misses        519      515       -4     
+ Partials      157      154       -3     
Flag Coverage Δ
unittests 86.51% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/apis/test.py 22.68% <ø> (ø)
mmseg/core/seg/sampler/base_pixel_sampler.py 100.00% <ø> (+16.66%) ⬆️
mmseg/datasets/pipelines/transforms.py 97.12% <ø> (ø)
mmseg/models/backbones/cgnet.py 96.75% <ø> (ø)
mmseg/models/backbones/hrnet.py 84.30% <ø> (ø)
mmseg/models/backbones/mobilenet_v3.py 97.47% <ø> (ø)
mmseg/models/decode_heads/apc_head.py 100.00% <ø> (ø)
mmseg/models/decode_heads/gc_head.py 95.23% <ø> (ø)
mmseg/models/losses/lovasz_loss.py 89.09% <ø> (ø)
mmseg/models/utils/se_layer.py 100.00% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a5d53...a4ac71d. Read the comment docs.

Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
@xvjiarui
Copy link
Collaborator

Good PR! Thx!

@xvjiarui xvjiarui merged commit 33e8357 into open-mmlab:master Mar 30, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* Fix typo: upsampe_cfg -> upsample_cfg

Signed-off-by: lizz <[email protected]>

* convoluton -> convolution

Signed-off-by: lizz <[email protected]>

* more

Signed-off-by: lizz <[email protected]>

* ok

Signed-off-by: lizz <[email protected]>
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* renamed variable names

q -> query
k -> key
v -> value
b -> batch
c -> channel
h -> height
w -> weight

* rename variable names

missed some in the initial commit

* renamed more variable names

As per  code review suggestions, renamed x -> hidden_states and x_in -> residual

* fixed minor typo
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants