-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support dataset initialization with file_client #1402
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
- Coverage 90.39% 90.39% -0.01%
==========================================
Files 133 133
Lines 7906 7903 -3
Branches 1318 1318
==========================================
- Hits 7147 7144 -3
Misses 536 536
Partials 223 223
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This month, we can do regression benchmarks with ceph to verify this PR.
…#1402) * [Feature] Support file_client in dataset initialization * docstring * revise osp.exist
…#1402) * [Feature] Support file_client in dataset initialization * docstring * revise osp.exist
* Upscaling fixed * up * more fixes * fix * more fixes * finish again * up
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support to initialize dataset from file_client
Modification
file_client_args
in__init__
with default valuedict(backend='disk')
file_client.list_dir_or_file
inload_annotations
mmcv.list_from_file
inload_annotations
Use cases (Optional)
Checklist