Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add HRSC dataset. Move eval_map to mmrotate.core.evaluation #54

Closed
wants to merge 5 commits into from

Conversation

liuyanyi
Copy link
Collaborator

@liuyanyi liuyanyi commented Mar 2, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add HRSC dataset.
Move eval_map to mmrotate.core.evaluation, like mmdet.core.evaluation, now dota and hrsc share same code of eval_map.

Modification

Implemented HRSCDataset based on XMLDataset in mmdet and HRSCDataset in OBBDetection.
Move evaluation code to mmrotate.core.evaluation.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@yangxue0827 yangxue0827 requested a review from zytx121 March 2, 2022 07:31
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #54 (cda1082) into dev (dd40984) will decrease coverage by 0.44%.
The diff coverage is 12.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #54      +/-   ##
==========================================
- Coverage   28.76%   28.31%   -0.45%     
==========================================
  Files         102      106       +4     
  Lines        6571     6820     +249     
  Branches      985     1031      +46     
==========================================
+ Hits         1890     1931      +41     
- Misses       4617     4825     +208     
  Partials       64       64              
Flag Coverage Δ
unittests 28.29% <12.97%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/core/evaluation/eval_map.py 7.58% <7.58%> (ø)
mmrotate/core/evaluation/recall.py 10.09% <10.09%> (ø)
mmrotate/datasets/hrsc.py 16.03% <16.03%> (ø)
mmrotate/core/__init__.py 100.00% <100.00%> (ø)
mmrotate/core/evaluation/__init__.py 100.00% <100.00%> (ø)
mmrotate/datasets/__init__.py 100.00% <100.00%> (ø)
mmrotate/datasets/dota.py 15.78% <100.00%> (+4.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd40984...cda1082. Read the comment docs.

� Conflicts:
�	mmrotate/datasets/dota.py
@zytx121 zytx121 added the WIP label Mar 5, 2022
@zytx121
Copy link
Collaborator

zytx121 commented Mar 5, 2022

Hi @liuyanyi
We welcome you to add new datasets to MMRotate! Thank you very much!
However, we recommend that you PR Move eval_map to mmrotate.core.evaluation firstly. You better split this PR into 2 PRs.

@liuyanyi
Copy link
Collaborator Author

liuyanyi commented Mar 5, 2022

Hi @liuyanyi We welcome you to add new datasets to MMRotate! Thank you very much! However, we recommend that you PR Move eval_map to mmrotate.core.evaluation firstly. You better split this PR into 2 PRs.

Sure, I will split that to 2 PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants