-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update docs/zh_cn/tutorials/customize_config.md #23
Conversation
1. translate `get_started.md` into Chinese 2. fix some typos in `en/get_started.md` 3. fix a broken link in `en/get_started.md`
add missing blank space
1. translate `customize_config.md` into Chinese 2. fix some grammatical errors in `en/tutorials/customize_config.md`
fix some typos
Hi @RangeKing |
@zytx121 Already reverted |
Thank you for your contributions. Please follow https://github.com/open-mmlab/mmcv/blob/master/CONTRIBUTING.md to set pre-commit and fix the lint error. |
@jbwang1997 Already fixed the lint error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me. Kindly ping @zytx121 to have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @RangeKing , |
Update code comments
Resolved. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Help build Chinese Documentation.
Modification
customize_config.md
andget_started.md
.customize_config.md
andget_started.md
.BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist