Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/zh_cn/tutorials/customize_runtime.md #22

Merged
merged 5 commits into from
Feb 23, 2022

Conversation

SheffieldCao
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Update the zh_cn docs file customize_runtime.md.

Modification

Translate original content into Chinese.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@yangxue0827
Copy link
Collaborator

关于空格和逗号和句号的格式,希望译者再完整仔细检查一遍,非常感谢!

@SheffieldCao
Copy link
Contributor Author

I’ve changed the typos mentioned above and checked the whole file again.

docs/zh_cn/tutorials/customize_runtime.md Outdated Show resolved Hide resolved
docs/zh_cn/tutorials/customize_runtime.md Outdated Show resolved Hide resolved
docs/zh_cn/tutorials/customize_runtime.md Outdated Show resolved Hide resolved
docs/zh_cn/tutorials/customize_runtime.md Outdated Show resolved Hide resolved
docs/zh_cn/tutorials/customize_runtime.md Outdated Show resolved Hide resolved
docs/zh_cn/tutorials/customize_runtime.md Outdated Show resolved Hide resolved
docs/zh_cn/tutorials/customize_runtime.md Outdated Show resolved Hide resolved
docs/zh_cn/tutorials/customize_runtime.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我认为没有什么问题了。

@yangxue0827
Copy link
Collaborator

@zytx121 lint check failed.

@jbwang1997
Copy link
Collaborator

jbwang1997 commented Feb 22, 2022

可以根据 https://github.com/open-mmlab/mmcv/blob/master/CONTRIBUTING.md 设置一下 pre-commit,修复 lint 的问题。

@ZwwWayne ZwwWayne merged commit 98e36b3 into open-mmlab:main Feb 23, 2022
@zytx121 zytx121 mentioned this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants