-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix warning with torch.meshgrid
.
#860
Conversation
Refer to open-mmlab/mmdetection#8090 (comment) for discussion on PyTorch version support of |
I have updated the PR with the same solution as used for mmpose and mmdet. This should be ready to merge now. |
Codecov ReportBase: 86.80% // Head: 85.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #860 +/- ##
==========================================
- Coverage 86.80% 85.39% -1.42%
==========================================
Files 130 134 +4
Lines 8571 8775 +204
Branches 1478 1435 -43
==========================================
+ Hits 7440 7493 +53
- Misses 909 1058 +149
- Partials 222 224 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
torch.meshgrid
.
Motivation
torch.meshgrid()
has started raising a warning when not called with an explicit indexing parameter:https://pytorch.org/docs/stable/generated/torch.meshgrid.html
Modification
Provide
indexing='ij'
to all calls totorch.meshgrid
that don't already specify indexing.Checklist
Before PR:
After PR: