-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support ConvNeXt #670
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #670 +/- ##
==========================================
+ Coverage 82.81% 83.00% +0.18%
==========================================
Files 123 124 +1
Lines 7293 7409 +116
Branches 1267 1289 +22
==========================================
+ Hits 6040 6150 +110
- Misses 1076 1077 +1
- Partials 177 182 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mmcls/models/backbones/convnext.py
Outdated
def __init__(self, | ||
in_channels, | ||
drop_path_rate=0., | ||
channels_last=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
channels_last
make users confused, users may see it as letting input tensor as shape (N, H, W, C), channel-dim in the last, but actually, It has nothing to do with the input tensor in our implement
maybe replace it with use_linear(bool)=False
like timm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* Support ConvNeXt * Add configs of ConvNeXt * Update dev scripts * Update docs. * Use new style README * Add unit tests. * Update README * Imporve according to comments * Modify refers to timm. * Imporve according to comments
Hello, in the original paper and code, there is a mention about layer-wise decay. |
In the official repo, layer-wise decay is not used in the classification task but in downstream tasks like seg and det. So we have not added this feature in future plans. And, this feature has been implemented in mmseg in open-mmlab/mmsegmentation#1216. If you want to use this in mmcls, you can transfer it from mmseg to mmcls. |
@Ezra-Yu Thank for your reply. |
* Support ConvNeXt * Add configs of ConvNeXt * Update dev scripts * Update docs. * Use new style README * Add unit tests. * Update README * Imporve according to comments * Modify refers to timm. * Imporve according to comments
Motivation
Support ConvNeXt and add converted checkpoints
Modification
As the title
Checklist
Before PR:
After PR: