-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support features_only in TIMMBackbone #668
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #668 +/- ##
==========================================
+ Coverage 82.12% 82.14% +0.01%
==========================================
Files 119 119
Lines 6865 6893 +28
Branches 1184 1192 +8
==========================================
+ Hits 5638 5662 +24
- Misses 1063 1066 +3
- Partials 164 165 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Support features_only in TIMMBackbone based on open-mmlab/mmsegmentation#998 * update test for mmdet * fix unit test for build_without_timm * Update docstring Co-authored-by: mzr1996 <[email protected]>
* Support features_only in TIMMBackbone based on open-mmlab/mmsegmentation#998 * update test for mmdet * fix unit test for build_without_timm * Update docstring Co-authored-by: mzr1996 <[email protected]>
Motivation
See the discussion in open-mmlab/mmdetection#7020. In MMDet, MMSeg, and other downstream repos, we wish to directly use backbones supported by TIMM in MMCls. Therefore, it is necessary to support this option for downstream tasks.
This PR will close #665.
This PR (especially
test_timm_backbone_features_only
) is based on open-mmlab/mmsegmentation#998.Modification
features_only=True
features_only=True
test_timm_backbone
Use cases (Optional)
MMDetection
Here is an example config
retinanet_timm_tv_resnet50_fpn_fp16_4x4_1x_coco.py
.The results at epoch 1 (
bbox_mAP_copypaste: 0.162 0.285 0.164 0.084 0.201 0.201
) are similar to those ofretinanet_r50_fpn_fp16_1x_coco.py
(bbox_mAP_copypaste: 0.164 0.284 0.168 0.082 0.189 0.203
).MMSegmentation
Here is an example config
upernet_timm_resnet50d_512x512_20k_voc12aug.py
.mIoU 69.75 at 2000 iter. umm... too high? I'm not familiar with mmseg, and the config may be wrong.
In any case, training and evaluation work.
Checklist
Before PR:
After PR: