Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support VoxelPose #999

Merged
merged 12 commits into from
Dec 3, 2021
Merged

[Feature] Support VoxelPose #999

merged 12 commits into from
Dec 3, 2021

Conversation

wusize
Copy link
Collaborator

@wusize wusize commented Nov 1, 2021

Motivation

Support VoxelPose Algorithm in MMPose.

Modification

  1. modify .dev_scripts/github/update_model_index.py to support multi-view 3d pose.
  2. Add mmpose/core/camera/single_camera_torch.py to apply camera-transformation in pytorch.
  3. Add affine_transform_torch in mmpose/core/post_processing/post_transforms.py.
  4. Add MultiItemProcess and MultiItemDeduplicate in mmpose/datasets/pipelines/shared_transform.py
  5. Delete unused variables (img) in mmpose/datasets/pipelines/bottom_up_transform.py.
  6. Add config, dataset, models/detector, models/head, models/backbone and related docs.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (dev-0.21@8fd5918). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             dev-0.21     #999   +/-   ##
===========================================
  Coverage            ?   81.93%           
===========================================
  Files               ?      198           
  Lines               ?    15336           
  Branches            ?     2707           
===========================================
  Hits                ?    12566           
  Misses              ?     2099           
  Partials            ?      671           
Flag Coverage Δ
unittests 81.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd5918...0a3d58a. Read the comment docs.

@jin-s13 jin-s13 added enhancement New feature or request need tests labels Nov 1, 2021
@jin-s13
Copy link
Collaborator

jin-s13 commented Nov 1, 2021

Need doc/log/ckpt.

@jin-s13 jin-s13 changed the title add voxelpose [Feature] Support VoxelPose Nov 1, 2021
@jin-s13 jin-s13 requested a review from ly015 November 1, 2021 09:49
@wusize
Copy link
Collaborator Author

wusize commented Nov 3, 2021

@ly015 Please help review the codes, especially the modification #1 to #5.

@ly015 ly015 changed the base branch from master to dev November 5, 2021 09:38
This was referenced Nov 18, 2021
@jin-s13 jin-s13 removed the enhancement New feature or request label Dec 1, 2021
@jin-s13
Copy link
Collaborator

jin-s13 commented Dec 1, 2021

Need to rebase to dev-0.21 @wusize

@wusize wusize merged commit 8a05c51 into dev-0.21 Dec 3, 2021
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* Bump version to v0.7.0

* Minor refine

* Fix as comment

* Add docs link

* update release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants