Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Halpe dataset #925

Merged
merged 13 commits into from
Oct 22, 2021
Merged

[Feature] Add Halpe dataset #925

merged 13 commits into from
Oct 22, 2021

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Sep 15, 2021

Motivation

Add Halpe dataset and related config files.

Modification

about halpe dataset

configs/_base_/datasets/halpe.py
mmpose/datasets/datasets/top_down/topdown_halpe_dataset.py
mmpose/datasets/datasets/__init__.py
mmpose/datasets/datasets/top_down/__init__.py

about configs

configs/wholebody/2d_kpt_sview_rgb_img/topdown_heatmap/halpe/hrnet_w32_halpe_256x192.py

small modifications to coco-wholebody to avoid possible errors.

mmpose/datasets/datasets/top_down/topdown_coco_wholebody_dataset.py

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@jin-s13 jin-s13 requested a review from ly015 September 15, 2021 09:28
@jin-s13 jin-s13 changed the title Add Halpe dataset [Feature] Add Halpe dataset Sep 15, 2021
@jin-s13 jin-s13 mentioned this pull request Oct 13, 2021
@jin-s13 jin-s13 mentioned this pull request Oct 13, 2021
11 tasks
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #925 (8ad1d6e) into master (0069aff) will decrease coverage by 0.02%.
The diff coverage is 72.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
- Coverage   82.82%   82.80%   -0.03%     
==========================================
  Files         189      190       +1     
  Lines       14146    14175      +29     
  Branches     2429     2433       +4     
==========================================
+ Hits        11716    11737      +21     
- Misses       1816     1821       +5     
- Partials      614      617       +3     
Flag Coverage Δ
unittests 82.73% <72.41%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/datasets/__init__.py 100.00% <ø> (ø)
...atasets/top_down/topdown_coco_wholebody_dataset.py 94.01% <0.00%> (-3.33%) ⬇️
...atasets/datasets/top_down/topdown_halpe_dataset.py 83.33% <83.33%> (ø)
mmpose/datasets/datasets/top_down/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0069aff...8ad1d6e. Read the comment docs.

@ly015 ly015 merged commit c918867 into master Oct 22, 2021
@jin-s13 jin-s13 deleted the halpe branch October 25, 2021 05:59
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
@luohao123
Copy link

@ly015 @jin-s13 Sorry for picking up this old PR here, but I noticed the above config are removed in latest mmpose.

May I ask where can I still get a workable (with latest mmpose) config file of Halpe dataset config file?

shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* add halpe datasets

* add halpe configs

* add halpe configs

* add halpe configs

* update configs

* rm unnecessary codes

* avoid duplicate names

* update keypoint name

* fix conflicts

* update info

* update cfg, ckpt

* add tests

* update halpe md
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* add halpe datasets

* add halpe configs

* add halpe configs

* add halpe configs

* update configs

* rm unnecessary codes

* avoid duplicate names

* update keypoint name

* fix conflicts

* update info

* update cfg, ckpt

* add tests

* update halpe md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants