Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Check the compatibility of inferencer's input/output #2567

Merged
merged 2 commits into from
Jul 24, 2023
Merged

[Fix] Check the compatibility of inferencer's input/output #2567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19c397e
add a check for input/output type
Ben-Louis Jul 24, 2023
80562bf
add ut for the check
Ben-Louis Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mmpose/apis/inferencers/pose2d_inferencer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,15 @@ def __call__(
else:
inputs = self._inputs_to_list(inputs)

# check the compatibility between inputs/outputs
if not self._video_input and len(inputs) > 0:
vis_out_dir = visualize_kwargs.get('vis_out_dir', None)
if vis_out_dir is not None:
_, file_extension = os.path.splitext(vis_out_dir)
assert not file_extension, f'the argument `vis_out_dir` ' \
f'should be a folder while the input contains multiple ' \
f'images, but got {vis_out_dir}'

forward_kwargs['bbox_thr'] = preprocess_kwargs.get('bbox_thr', -1)
inputs = self.preprocess(
inputs, batch_size=batch_size, **preprocess_kwargs)
Expand Down
9 changes: 9 additions & 0 deletions mmpose/apis/inferencers/pose3d_inferencer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,15 @@ def __call__(
else:
inputs = self._inputs_to_list(inputs)

# check the compatibility between inputs/outputs
if not self._video_input and len(inputs) > 0:
vis_out_dir = visualize_kwargs.get('vis_out_dir', None)
if vis_out_dir is not None:
_, file_extension = os.path.splitext(vis_out_dir)
assert not file_extension, f'the argument `vis_out_dir` ' \
f'should be a folder while the input contains multiple ' \
f'images, but got {vis_out_dir}'

inputs = self.preprocess(
inputs, batch_size=batch_size, **preprocess_kwargs)

Expand Down
4 changes: 4 additions & 0 deletions tests/test_apis/test_inferencers/test_pose2d_inferencer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ def test_call(self):
self.assertSequenceEqual(results1['predictions'][0][0]['keypoints'],
results3['predictions'][3][0]['keypoints'])

with self.assertRaises(AssertionError):
for res in inferencer(inputs, vis_out_dir=f'{tmp_dir}/1.jpg'):
pass

# `inputs` is path to a video
inputs = 'tests/data/posetrack18/videos/000001_mpiinew_test/' \
'000001_mpiinew_test.mp4'
Expand Down
Loading