Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix merge_args in tools/test.py #2431

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Ben-Louis Ben-Louis requested a review from Tau-J June 6, 2023 10:13
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ef98c3) 79.29% compared to head (1889698) 79.29%.

❗ Current head 1889698 differs from pull request most recent head badcfea. Consider uploading reports for the commit badcfea to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2431   +/-   ##
========================================
  Coverage    79.29%   79.29%           
========================================
  Files          248      248           
  Lines        14859    14859           
  Branches      2577     2577           
========================================
  Hits         11782    11782           
  Misses        2499     2499           
  Partials       578      578           
Flag Coverage Δ
unittests 79.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit 79f7cf7 into open-mmlab:dev-1.x Jun 6, 2023
@Ben-Louis Ben-Louis deleted the fix-test.py branch July 10, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants