Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix 1d heatmap visualization problem #2092

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

nixsui
Copy link
Contributor

@nixsui nixsui commented Mar 19, 2023

Fix 1d heatmap visualization problem, change the method of generating background image from:

        blank = np.zeros((size[0] * 2, size[1] * 2, 3), np.uint8)

to:

        blank_height = int(
            max(size[0] * 2, size[0] * 1.1 + (K + 1) * (15 + interval)))
        blank_width = int(
            max(size[1] * 2, size[1] * 1.1 + (K + 1) * (15 + interval)))
        blank = np.zeros((blank_height, blank_width, 3), np.uint8)

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2023

CLA assistant check
All committers have signed the CLA.

@ly015 ly015 requested a review from Tau-J March 20, 2023 02:53
@nixsui nixsui force-pushed the nixsui/fix_1d_heatmap_vis branch from 17e66d9 to 0e70aff Compare March 21, 2023 04:33
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (3af7fed) 81.46% compared to head (c0d1d4c) 81.47%.

❗ Current head c0d1d4c differs from pull request most recent head 0e70aff. Consider uploading reports for the commit 0e70aff to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2092      +/-   ##
===========================================
+ Coverage    81.46%   81.47%   +0.01%     
===========================================
  Files          227      227              
  Lines        13513    13515       +2     
  Branches      2306     2306              
===========================================
+ Hits         11008    11012       +4     
+ Misses        1987     1983       -4     
- Partials       518      520       +2     
Flag Coverage Δ
unittests 81.47% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/visualization/simcc_vis.py 98.66% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 changed the title Fix 1d heatmap visualization problem [Fix] fix 1d heatmap visualization problem Mar 21, 2023
@Tau-J Tau-J merged commit 3d97110 into open-mmlab:dev-1.x Mar 23, 2023
@nixsui nixsui deleted the nixsui/fix_1d_heatmap_vis branch March 24, 2023 02:54
@OpenMMLab-Assistant-004

Hi @nixsui !First of all, we want to express our gratitude for your significant PR in the mmpose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants