-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Use opencv backend in Webcam API visualization #2089
[Fix] Use opencv backend in Webcam API visualization #2089
Conversation
b92ce32
to
8f827f6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2089 +/- ##
===========================================
- Coverage 81.92% 81.49% -0.43%
===========================================
Files 227 227
Lines 13447 13513 +66
Branches 2286 2306 +20
===========================================
- Hits 11017 11013 -4
- Misses 1913 1980 +67
- Partials 517 520 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -51,6 +52,10 @@ def set_device(cfg: Config, device: str): | |||
|
|||
|
|||
def run(): | |||
|
|||
warnings.warn('The Webcam API will be deprecated in future. ', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a reference to the inferencer-based webcam demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, the inferencer utilizing webcam input encounters a similar issue as the webcam API, where the visualization process is too slow to render keypoints in real time. As a result, users might have a less satisfactory experience with the inferencer compared to the updated webcam API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think this PR can be merged as it is.
Motivation
The visualization step in Webcam API is slow due the matplotlib backend used by PoseVisualizer (#2035)
Modification
imshow_bboxes
andimshow_keypoints
, which are used by Webcam API in 0.x version for visualization, to replace PoseVisualizerwebcam_demo
towebcam_api_demo
demo/webcam_api_demo.py
BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: