Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] update mmcv compatibility information in FAQ #1991

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Feb 21, 2023

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015 ly015 changed the title [Fix] update required mmcv version [Fix] update mmcv compatibility information in FAQ Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 84.03% // Head: 84.00% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (1589e2d) compared to base (1f11d6c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
- Coverage   84.03%   84.00%   -0.03%     
==========================================
  Files         241      241              
  Lines       20869    20869              
  Branches     3609     3609              
==========================================
- Hits        17537    17531       -6     
- Misses       2406     2411       +5     
- Partials      926      927       +1     
Flag Coverage Δ
unittests 83.94% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/models/utils/misc.py 71.42% <0.00%> (-28.58%) ⬇️
mmpose/datasets/pipelines/top_down_transform.py 75.27% <0.00%> (-1.12%) ⬇️
mmpose/datasets/pipelines/shared_transform.py 82.43% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 merged commit cbac880 into open-mmlab:master Feb 21, 2023
@ly015 ly015 deleted the update-mmcv-master branch February 21, 2023 07:29
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 5, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants