Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] update mmcv/mmengine compatibility information in FAQ #1990

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Feb 21, 2023

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015 ly015 force-pushed the update-mmcv-1.x branch 3 times, most recently from 8fee953 to 9fdbebf Compare February 21, 2023 06:23
@ly015 ly015 requested a review from Tau-J February 21, 2023 06:23
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 82.20% // Head: 82.08% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (3f0cab2) compared to base (a2b2a31).
Patch has no changes to coverable lines.

❗ Current head 3f0cab2 differs from pull request most recent head aed83b0. Consider uploading reports for the commit aed83b0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1990      +/-   ##
===========================================
- Coverage    82.20%   82.08%   -0.12%     
===========================================
  Files          214      214              
  Lines        12736    12736              
  Branches      2154     2154              
===========================================
- Hits         10469    10454      -15     
- Misses        1806     1816      +10     
- Partials       461      466       +5     
Flag Coverage Δ
unittests 82.08% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/codecs/associative_embedding.py 86.87% <0.00%> (-9.38%) ⬇️
mmpose/datasets/transforms/common_transforms.py 85.38% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 changed the base branch from 1.x to dev-1.x February 21, 2023 06:28
@ly015 ly015 changed the base branch from dev-1.x to 1.x February 21, 2023 06:29
@ly015 ly015 changed the base branch from 1.x to dev-1.x February 21, 2023 06:31
@ly015 ly015 merged commit 3b0b41b into open-mmlab:dev-1.x Feb 21, 2023
@ly015 ly015 deleted the update-mmcv-1.x branch February 21, 2023 07:15
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants