-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Specify mmengine version #1715
Conversation
Codecov ReportBase: 77.75% // Head: 77.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #1715 +/- ##
===========================================
+ Coverage 77.75% 77.77% +0.01%
===========================================
Files 204 204
Lines 11716 11712 -4
Branches 1956 1953 -3
===========================================
- Hits 9110 9109 -1
+ Misses 2206 2204 -2
+ Partials 400 399 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -1 +1,2 @@ | |||
poseval@git+https://github.com/svenkreiss/poseval.git | |||
shapely==1.8.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is shapely
required by poseval
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems already in the requirements of poseval
(https://github.com/svenkreiss/poseval/blob/master/setup.py#L15). Won't it be automatically installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a new release of shapely
today (v1.8.5), which will be automatically installed. This version of shapely
seems incompatible with the unittest environment, and will make CI fail.
* specify mmengine version * fix denpendency version
* specify mmengine version * fix denpendency version
* specify mmengine version * fix denpendency version
Motivation
Modification
BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: