Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Specify mmengine version #1715

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 77.75% // Head: 77.77% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (dbe0c44) compared to base (e65108a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1715      +/-   ##
===========================================
+ Coverage    77.75%   77.77%   +0.01%     
===========================================
  Files          204      204              
  Lines        11716    11712       -4     
  Branches      1956     1953       -3     
===========================================
- Hits          9110     9109       -1     
+ Misses        2206     2204       -2     
+ Partials       400      399       -1     
Flag Coverage Δ
unittests 77.77% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/version.py 70.58% <ø> (ø)
mmpose/__init__.py 100.00% <100.00%> (+5.88%) ⬆️
mmpose/datasets/transforms/common_transforms.py 83.47% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ben-Louis Ben-Louis requested a review from ly015 October 13, 2022 03:41
@@ -1 +1,2 @@
poseval@git+https://github.com/svenkreiss/poseval.git
shapely==1.8.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is shapely required by poseval?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems already in the requirements of poseval (https://github.com/svenkreiss/poseval/blob/master/setup.py#L15). Won't it be automatically installed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new release of shapely today (v1.8.5), which will be automatically installed. This version of shapely seems incompatible with the unittest environment, and will make CI fail.

@ly015 ly015 merged commit 44a21f7 into open-mmlab:dev-1.x Oct 13, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
* specify mmengine version

* fix denpendency version
ly015 pushed a commit that referenced this pull request Oct 14, 2022
* specify mmengine version

* fix denpendency version
@Ben-Louis Ben-Louis deleted the specify-mmengine-version branch November 15, 2022 08:40
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* specify mmengine version

* fix denpendency version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants