-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix a visualization bug and refine dataset browser #1668
Conversation
|
Codecov ReportBase: 70.34% // Head: 70.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #1668 +/- ##
===========================================
+ Coverage 70.34% 70.37% +0.03%
===========================================
Files 203 203
Lines 11558 11564 +6
Branches 2019 2021 +2
===========================================
+ Hits 8130 8138 +8
+ Misses 3083 3078 -5
- Partials 345 348 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Solved. The corresponding unittest is add in #1662 |
* fix visualizer's dataset_meta error in visualization_hook with multiple GPUs * refine dataset browser * use string typehint for compatibility with python3.6 * update unittest for visualizer and visulization_hook * refine visualizer to avoid saving duplicated images with visualization_hook * refine dataset browser
* fix visualizer's dataset_meta error in visualization_hook with multiple GPUs * refine dataset browser * use string typehint for compatibility with python3.6 * update unittest for visualizer and visulization_hook * refine visualizer to avoid saving duplicated images with visualization_hook * refine dataset browser
…1668) * fix visualizer's dataset_meta error in visualization_hook with multiple GPUs * refine dataset browser * use string typehint for compatibility with python3.6 * update unittest for visualizer and visulization_hook * refine visualizer to avoid saving duplicated images with visualization_hook * refine dataset browser
Motivation
Modification
When testing with multiple GPUs, there are multiple processes but only one
visualizer
. Thevisualizer.dataset_meta
is manually set toNone
occasionally in some processes in test_loop. This may lead toAttributeError
in other processes when getting items fromvisualizer.dataset_meta
.file_client
to read image instead ofmmcv.imread
bbox_file
in dataset configs. Thus the visualization results match the images model receives indeed.BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: