Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] smooth 2D instead of 3D keypoints in body3d_two_stage_video_demo.py #1479

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Conversation

darcula1993
Copy link

@darcula1993 darcula1993 commented Jul 11, 2022

smooth 2d results rather than 3d results show better performance

Motivation

smooth 2d results rather than 3d results show better performance

Modification

smooth 2d results before 2d-to-3d lift process.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

smooth 2d results rather than 3d results show better performance
@CLAassistant
Copy link

CLAassistant commented Jul 11, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1479 (d3d2328) into master (bf9bd53) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1479      +/-   ##
==========================================
- Coverage   84.47%   84.46%   -0.01%     
==========================================
  Files         236      236              
  Lines       20036    20036              
  Branches     3602     3602              
==========================================
- Hits        16925    16924       -1     
  Misses       2231     2231              
- Partials      880      881       +1     
Flag Coverage Δ
unittests 84.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/pipelines/shared_transform.py 83.26% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeebc65...d3d2328. Read the comment docs.

@ly015
Copy link
Member

ly015 commented Jul 11, 2022

Thank you very much for your help. Could you please sign the CLA?

Do you think it would be better to smooth both 2D and 3D keypoints? Or it's good enough to apply smoothing only on 2D keypoints.

@darcula1993
Copy link
Author

Thank you very much for your help. Could you please sign the CLA?

Do you think it would be better to smooth both 2D and 3D keypoints? Or it's good enough to apply smoothing only on 2D keypoints.

According to my test, smooth 2d results with one euro filter config
filter_cfg = dict( type='OneEuroFilter', min_cutoff=0.00001, beta=0.007, )
is good enough.
here is the demo video link:https://mega.nz/folder/3eZVXQqa#6wquV75L-Sdc9Hf9ZmM3Gg
I use faster_rcnn_r50_fpn_1x_coco_20200130-047c8118.pth for detection and hrnet_w48_coco_256x192-b9e0b3ab_20200708.pth for 2d pose,and videopose3d 1 frame model with retrain weights by myself.

@ly015 ly015 merged commit 3c8e19f into open-mmlab:master Jul 12, 2022
@ly015 ly015 changed the title Update body3d_two_stage_video_demo.py [Enhance] smooth 2D instead of 3D keypoints in body3d_two_stage_video_demo.py Jul 12, 2022
wusize pushed a commit that referenced this pull request Jul 20, 2022
* Update body3d_two_stage_video_demo.py

smooth 2d results rather than 3d results show better performance

* fix lint

Co-authored-by: ly015 <[email protected]>
evendrow pushed a commit to evendrow/mmpose that referenced this pull request Dec 22, 2022
* Update body3d_two_stage_video_demo.py

smooth 2d results rather than 3d results show better performance

* fix lint

Co-authored-by: ly015 <[email protected]>
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 5, 2023
* Update body3d_two_stage_video_demo.py

smooth 2d results rather than 3d results show better performance

* fix lint

Co-authored-by: ly015 <[email protected]>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* Update body3d_two_stage_video_demo.py

smooth 2d results rather than 3d results show better performance

* fix lint

Co-authored-by: ly015 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants