-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] smooth 2D instead of 3D keypoints in body3d_two_stage_video_demo.py #1479
Conversation
smooth 2d results rather than 3d results show better performance
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
==========================================
- Coverage 84.47% 84.46% -0.01%
==========================================
Files 236 236
Lines 20036 20036
Branches 3602 3602
==========================================
- Hits 16925 16924 -1
Misses 2231 2231
- Partials 880 881 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thank you very much for your help. Could you please sign the CLA? Do you think it would be better to smooth both 2D and 3D keypoints? Or it's good enough to apply smoothing only on 2D keypoints. |
According to my test, smooth 2d results with one euro filter config |
* Update body3d_two_stage_video_demo.py smooth 2d results rather than 3d results show better performance * fix lint Co-authored-by: ly015 <[email protected]>
* Update body3d_two_stage_video_demo.py smooth 2d results rather than 3d results show better performance * fix lint Co-authored-by: ly015 <[email protected]>
* Update body3d_two_stage_video_demo.py smooth 2d results rather than 3d results show better performance * fix lint Co-authored-by: ly015 <[email protected]>
* Update body3d_two_stage_video_demo.py smooth 2d results rather than 3d results show better performance * fix lint Co-authored-by: ly015 <[email protected]>
smooth 2d results rather than 3d results show better performance
Motivation
smooth 2d results rather than 3d results show better performance
Modification
smooth 2d results before 2d-to-3d lift process.
BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: