Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] rename custom_hooks_config to custom_hooks #1427

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Jun 14, 2022

Motivation

Change 'custom_hooks_config' to 'custom_hooks' in configs following the OpenMMLab convention. Compatibility to the old-style config is handled.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015 ly015 requested a review from jin-s13 June 14, 2022 06:30
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1427 (01574c0) into master (4f5ec97) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
- Coverage   84.35%   84.32%   -0.03%     
==========================================
  Files         232      232              
  Lines       19279    19284       +5     
  Branches     3468     3470       +2     
==========================================
  Hits        16262    16262              
- Misses       2152     2157       +5     
  Partials      865      865              
Flag Coverage Δ
unittests 84.26% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/train.py 21.05% <0.00%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5ec97...01574c0. Read the comment docs.

@ly015 ly015 merged commit 8890aa3 into open-mmlab:master Jun 15, 2022
wusize pushed a commit that referenced this pull request Jun 30, 2022
* rename custom_hooks_config to custom_hooks
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 5, 2023
* rename custom_hooks_config to custom_hooks
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* rename custom_hooks_config to custom_hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants