Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix data collate and scatter in inference #1175

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Feb 10, 2022

Motivation

  • Correct samples_per_gpu argument of collate() in inference
  • Use scatter() instead of manually scatterring DataContainer
  • Remove LoadImage and directly use test_pipeline of the model. Modify LoadImageFromFile to support manually set 'img' in results.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015 ly015 changed the base branch from master to dev-0.23 February 10, 2022 09:37
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev-0.24@fd1e4fb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             dev-0.24    #1175   +/-   ##
===========================================
  Coverage            ?   82.72%           
===========================================
  Files               ?      204           
  Lines               ?    16349           
  Branches            ?     2942           
===========================================
  Hits                ?    13525           
  Misses              ?     2079           
  Partials            ?      745           
Flag Coverage Δ
unittests 82.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1e4fb...a911775. Read the comment docs.

@ly015 ly015 changed the base branch from dev-0.23 to dev-0.24 February 28, 2022 12:57
@ly015 ly015 force-pushed the fix-inference branch 2 times, most recently from 5b122fd to 40507b1 Compare February 28, 2022 15:15
@ly015 ly015 merged commit 23d671e into open-mmlab:dev-0.24 Mar 1, 2022
ly015 added a commit that referenced this pull request Mar 7, 2022
* clean inference code

* LoadImageFromFile supports given img
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* clean inference code

* LoadImageFromFile supports given img
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* clean inference code

* LoadImageFromFile supports given img
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants