Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support score_per_joint in group and nms #1170

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

piercus
Copy link
Contributor

@piercus piercus commented Feb 5, 2022

Motivation

#1169

Modification

  • Add a param score_per_joint in the HeatmapParser group algorithm
  • Change ok_nms algorithm to take this into consideration

BC-breaking (Optional)

No

Use cases (Optional)

See #1169

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #1170 (7844618) into master (d5fd7c6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
- Coverage   82.46%   82.45%   -0.02%     
==========================================
  Files         203      203              
  Lines       16069    16077       +8     
  Branches     2862     2868       +6     
==========================================
+ Hits        13252    13256       +4     
- Misses       2095     2099       +4     
  Partials      722      722              
Flag Coverage Δ
unittests 82.40% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/inference.py 49.15% <100.00%> (+0.17%) ⬆️
mmpose/core/post_processing/group.py 82.94% <100.00%> (+0.30%) ⬆️
mmpose/core/post_processing/nms.py 89.58% <100.00%> (+0.45%) ⬆️
mmpose/datasets/pipelines/top_down_transform.py 64.00% <0.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca589a...7844618. Read the comment docs.

@jin-s13 jin-s13 requested a review from ly015 February 7, 2022 06:42
@ly015 ly015 changed the base branch from master to dev-0.23 February 9, 2022 02:40
@ly015 ly015 changed the title [Fix] #1169 score_per_joint [Feature] Support score_per_joint in group and nms Feb 9, 2022
@ly015 ly015 changed the base branch from dev-0.23 to master February 9, 2022 02:45
@ly015
Copy link
Member

ly015 commented Feb 9, 2022

Hi @piercus , your contribution is very much appreciated.

Would mind taking one more step to bring the codecov rate up to the standard (details can be found here)? Thanks in advance.

@piercus
Copy link
Contributor Author

piercus commented Feb 10, 2022

@ly015 thanks for the feedback, I have added some coverage, i feel i'm covering 100% of my changes, not sure why codecov/project is still failing

@ly015
Copy link
Member

ly015 commented Feb 11, 2022

@piercus Thanks. It's probably a codecov issue and the PR looks good.

@ly015 ly015 merged commit 75add9f into open-mmlab:master Feb 11, 2022
ly015 pushed a commit to ly015/mmpose that referenced this pull request Feb 11, 2022
* [Fix] open-mmlab#1169 score_per_joint

* [Fix] docstring

* [Fix] open-mmlab#1169 coverage following review remark open-mmlab#1170 (comment)
@jin-s13 jin-s13 mentioned this pull request May 25, 2022
@OpenMMLab-Assistant005
Copy link

Dear piercus,
First of all, we want to express our gratitude for your significant PR in the MMPose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG
Thank you again for your contribution❤
Best regards! @piercus

HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants