-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support score_per_joint in group and nms #1170
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
- Coverage 82.46% 82.45% -0.02%
==========================================
Files 203 203
Lines 16069 16077 +8
Branches 2862 2868 +6
==========================================
+ Hits 13252 13256 +4
- Misses 2095 2099 +4
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@ly015 thanks for the feedback, I have added some coverage, i feel i'm covering 100% of my changes, not sure why codecov/project is still failing |
@piercus Thanks. It's probably a codecov issue and the PR looks good. |
* [Fix] open-mmlab#1169 score_per_joint * [Fix] docstring * [Fix] open-mmlab#1169 coverage following review remark open-mmlab#1170 (comment)
Dear piercus, |
Motivation
#1169
Modification
BC-breaking (Optional)
No
Use cases (Optional)
See #1169
Checklist
Before PR:
After PR: