-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add two traditional filters to smooth poses #1127
Conversation
Pls follow https://github.com/open-mmlab/mmpose/blob/master/.github/CONTRIBUTING.md to setup pre-commit. |
Codecov Report
@@ Coverage Diff @@
## dev-0.25 #1127 +/- ##
============================================
+ Coverage 83.44% 83.47% +0.03%
============================================
Files 205 212 +7
Lines 16625 16821 +196
Branches 2976 3010 +34
============================================
+ Hits 13872 14042 +170
- Misses 2001 2012 +11
- Partials 752 767 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* add Smoother * refactor filters with base filter * add unittest for Smoother
update get_track_id and demos
|
||
|
||
class OneEuro: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need any description here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the newly reimplemented One-Euro filter. The one that will be deprecated is in mmpose/core/post_processing/one_euro_filter.py
.
* add savgol&gaus1d filters * Update __init__.py * Update test_temporal_filter.py * Update and rename gaus1d_filter.py to gauss1d_filter.py * Update __init__.py * pass pre-commit hooks * Add smoother * add Smoother * refactor filters with base filter * add unittest for Smoother * add temporal filter unittests * remove misadded file * fix bugs in smoother and filters update get_track_id and demos * fix unittest * fix smoother bug with empty input * fix smoothing in 3d video demo Co-authored-by: ly015 <[email protected]>
* add savgol&gaus1d filters * Update __init__.py * Update test_temporal_filter.py * Update and rename gaus1d_filter.py to gauss1d_filter.py * Update __init__.py * pass pre-commit hooks * Add smoother * add Smoother * refactor filters with base filter * add unittest for Smoother * add temporal filter unittests * remove misadded file * fix bugs in smoother and filters update get_track_id and demos * fix unittest * fix smoother bug with empty input * fix smoothing in 3d video demo Co-authored-by: ly015 <[email protected]>
Hi @ailingzengzzz !First of all, we want to express our gratitude for your significant PR in the mmpose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
* add savgol&gaus1d filters * Update __init__.py * Update test_temporal_filter.py * Update and rename gaus1d_filter.py to gauss1d_filter.py * Update __init__.py * pass pre-commit hooks * Add smoother * add Smoother * refactor filters with base filter * add unittest for Smoother * add temporal filter unittests * remove misadded file * fix bugs in smoother and filters update get_track_id and demos * fix unittest * fix smoother bug with empty input * fix smoothing in 3d video demo Co-authored-by: ly015 <[email protected]>
* add savgol&gaus1d filters * Update __init__.py * Update test_temporal_filter.py * Update and rename gaus1d_filter.py to gauss1d_filter.py * Update __init__.py * pass pre-commit hooks * Add smoother * add Smoother * refactor filters with base filter * add unittest for Smoother * add temporal filter unittests * remove misadded file * fix bugs in smoother and filters update get_track_id and demos * fix unittest * fix smoother bug with empty input * fix smoothing in 3d video demo Co-authored-by: ly015 <[email protected]>
Motivation
Smooth poses.
Modification
Smoother
module for pose smoothing, which applies a temporal filter on pose sequence.Use Cases
Init smoother
Online smoothing (frame-by-frame)
Offline smoothing
BC-Breaking
The arguments
use_one_euro
andfps
in functionget_track_id()
will be deprecated in the future. Deprecation warnings have been added in this PR.Checklist
Before PR:
After PR: