Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Change mmcv.dump to mmengine.dump #1540

Merged
merged 1 commit into from
Nov 16, 2022
Merged

[Fix] Change mmcv.dump to mmengine.dump #1540

merged 1 commit into from
Nov 16, 2022

Conversation

ProtossDragoon
Copy link
Contributor

@ProtossDragoon ProtossDragoon commented Nov 16, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

bash

python3 -m mmocr.ocr \
--det DB_r18 \
--recog CRNN \
demo/demo_text_ocr.jpg \
--pred-out-file temp/demo_text_ocr.pkl

output

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/root/dev/oss/src_mmocr/mmocr/ocr.py", line 487, in <module>
    main()
  File "/root/dev/oss/src_mmocr/mmocr/ocr.py", line 483, in main
    ocr.readtext(**vars(args))
  File "/root/dev/oss/src_mmocr/mmocr/ocr.py", line 217, in readtext
    return self.inferencer(
  File "/root/dev/oss/src_mmocr/mmocr/apis/inferencers/base_mmocr_inferencer.py", line 149, in __call__
    results = self.postprocess(
  File "/root/dev/oss/src_mmocr/mmocr/apis/inferencers/mmocr_inferencer.py", line 214, in postprocess
    mmcv.dump(results, pred_out_file)
AttributeError: module 'mmcv' has no attribute 'dump'

Modification

dump method was removed from MMCV 2.x. Use mmengine.dump instead.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

- `dump` method was removed from MMCV 2.x. `Use mmengine.dump` instead.
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2022

CLA assistant check
All committers have signed the CLA.

@gaotongxiao
Copy link
Collaborator

Hi, thanks for your contribution! Before we are able to merge your PR, please don't forget to sign CLA here :)

image

Also, if you get an error message like "xxx seems not to be a GitHub user", it means that the email you used to commit changes does not match the one you used in your GitHub account. You can try to link your local email to your GitHub, or update your local email address and then amend your commits:

git config --global user.email "YOUR_GITHUB_EMAIL"
git commit --amend

@gaotongxiao gaotongxiao merged commit b1a3b94 into open-mmlab:dev-1.x Nov 16, 2022
@ProtossDragoon ProtossDragoon deleted the dev-1.x branch November 17, 2022 07:57
@OpenMMLab-Assistant005
Copy link

Dear ProtossDragoon,
First of all, we want to express our gratitude for your significant PR in the MMOCR project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG
Thank you again for your contribution❤
Best regards! @ProtossDragoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants