Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Upgrade isort in pre-commit hook #87

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

MeowZheng
Copy link
Collaborator

Modification

  1. Remove seed-isort-config in pre-commit hook
  2. Upgrade isort to v5.10.1 (latest version)
  3. Replace known_standard_library with extra_standard_library

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #87 (249bfba) into master (0523c58) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   67.80%   67.88%   +0.08%     
==========================================
  Files          86       86              
  Lines        4895     4895              
  Branches      705      705              
==========================================
+ Hits         3319     3323       +4     
+ Misses       1468     1464       -4     
  Partials      108      108              
Flag Coverage Δ
unittests 67.88% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmflow/datasets/pipelines/transforms.py 78.66% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0523c58...249bfba. Read the comment docs.

@MeowZheng
Copy link
Collaborator Author

Why replace known_standard_library with extra_standard_library?
image
ref: https://pycqa.github.io/isort/docs/upgrade_guides/5.0.0.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant