Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Lion optimizer #952

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

zhouzaida
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add Lion optimizer from https://github.com/lucidrains/lion-pytorch

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

No

Use cases (Optional)

optim_wrapper = dict(
    type='OptimWrapper',
    optimizer=dict(type='Lion', lr=1e-4)
)

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@25dfe41). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 636521d differs from pull request most recent head 756b524. Consider uploading reports for the commit 756b524 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage        ?   76.66%           
=======================================
  Files           ?      138           
  Lines           ?    10827           
  Branches        ?     2163           
=======================================
  Hits            ?     8300           
  Misses          ?     2170           
  Partials        ?      357           
Flag Coverage Δ
unittests 76.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida merged commit fc9518e into open-mmlab:main Feb 23, 2023
@zhouzaida zhouzaida deleted the support-lion-optimizer branch February 23, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants