Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Temporarily fix collect_env raise errors and stops programs #944

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

C1rN09
Copy link
Collaborator

@C1rN09 C1rN09 commented Feb 21, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

See issue #931

There might also be some corner cases that raises error during collecting compiler information. We should not stop the user's program from running due to these exceptions.

Modification

Captures all exceptions and records the reason instead of raises exceptions.

BC-breaking (Optional)

No

Use cases (Optional)

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e16dacf). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head e5295a6 differs from pull request most recent head ae45a86. Consider uploading reports for the commit ae45a86 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage        ?   76.78%           
=======================================
  Files           ?      138           
  Lines           ?    10797           
  Branches        ?     2156           
=======================================
  Hits            ?     8291           
  Misses          ?     2148           
  Partials        ?      358           
Flag Coverage Δ
unittests 76.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@C1rN09 C1rN09 marked this pull request as draft February 21, 2023 06:12
@zhouzaida zhouzaida changed the title [Fix] temporarily fix collect_env raise errors and stops programs [Fix] Temporarily fix collect_env raise errors and stops programs Feb 21, 2023
@zhouzaida zhouzaida merged commit e271454 into open-mmlab:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] UnsupportedOperation: fileno on runner (1.X MMClassification)
2 participants