Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] beautify the print result of the registry #922

Merged
merged 4 commits into from
Feb 14, 2023

Conversation

Eiuyc
Copy link
Contributor

@Eiuyc Eiuyc commented Feb 10, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

For better debug usages

Modification

  • requirements/runtime.txt
    • add tabulate requirement
  • mmengine\registry\registry.py
    • use tabulate to format the repr str
  • tests\test_registry\test_registry.py
    • modify the repr test

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Eiuyc Eiuyc marked this pull request as ready for review February 10, 2023 14:29
@zhouzaida zhouzaida linked an issue Feb 11, 2023 that may be closed by this pull request
requirements/runtime.txt Outdated Show resolved Hide resolved
@zhouzaida
Copy link
Collaborator

zhouzaida commented Feb 12, 2023

Hi @Eiuyc , thanks for your contribution. This result is beautiful.
image
image

@Eiuyc
Copy link
Contributor Author

Eiuyc commented Feb 12, 2023

Hi @Eiuyc , thanks for your contribution. This result is beautiful. image image

Thank you! I'm happy to hear that.

@ZwwWayne
Copy link
Collaborator

Overall, this PR looks good to me, and the printed results are pretty.

@Eiuyc Eiuyc force-pushed the eiuyc/beautify_print_of_registry branch from fef6d56 to 736e5cd Compare February 14, 2023 06:06
@Eiuyc
Copy link
Contributor Author

Eiuyc commented Feb 14, 2023

Hi, the code has been updated, please review.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c712070). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 2570cde differs from pull request most recent head cce27ed. Consider uploading reports for the commit cce27ed to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage        ?   77.92%           
=======================================
  Files           ?      133           
  Lines           ?    10097           
  Branches        ?     2011           
=======================================
  Hits            ?     7868           
  Misses          ?     1888           
  Partials        ?      341           
Flag Coverage Δ
unittests 77.92% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida
Copy link
Collaborator

zhouzaida commented Feb 14, 2023

Hi, the code has been updated, please review.

Look good to me. Thanks for your contribution.

image

Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!!!
image

@zhouzaida zhouzaida merged commit c59899a into open-mmlab:main Feb 14, 2023
@jason102811
Copy link

Hi @Eiuyc !First of all, we want to express our gratitude for your significant PR in the MMEngine . Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine repr of Registry
5 participants